small code improvements

src/main/java/net/engio/mbassy/common/AbstractConcurrentSet.java

@@ -28,18 +28,16 @@ public abstract class AbstractConcurrentSet<T> implements IConcurrentSet<T> {
     protected abstract Entry<T> createEntry(T value, Entry<T> next);
 
     @Override
-    public IConcurrentSet<T> add(T element) {
+    public void add(T element) {
-        if (element == null) return this;
+        if (element == null) return;
         Lock writeLock = lock.writeLock();
         writeLock.lock();
         if (element == null || entries.containsKey(element)) {
             writeLock.unlock();
-            return this;
         } else {
             insert(element);
             writeLock.unlock();
         }
-        return this;
     }
 
     @Override
@@ -69,7 +67,7 @@ public abstract class AbstractConcurrentSet<T> implements IConcurrentSet<T> {
     }
 
     @Override
-    public IConcurrentSet<T> addAll(Iterable<T> elements) {
+    public void addAll(Iterable<T> elements) {
         Lock writeLock = lock.writeLock();
         try {
             writeLock.lock();
@@ -81,7 +79,6 @@ public abstract class AbstractConcurrentSet<T> implements IConcurrentSet<T> {
         } finally {
             writeLock.unlock();
         }
-        return this;
     }
 
     @Override

src/main/java/net/engio/mbassy/common/IConcurrentSet.java

@@ -8,13 +8,13 @@ package net.engio.mbassy.common;
  */
 public interface IConcurrentSet<T> extends Iterable<T> {
 
-    IConcurrentSet<T> add(T element);
+    void add(T element);
 
     boolean contains(T element);
 
     int size();
 
-    IConcurrentSet<T> addAll(Iterable<T> elements);
+    void addAll(Iterable<T> elements);
 
     boolean remove(T element);
 }

src/main/java/net/engio/mbassy/listener/MessageHandler.java

@@ -56,7 +56,7 @@ public class MessageHandler {
             Map<String, Object> properties = new HashMap<String, Object>();
             properties.put(HandlerMethod, handler);
             // add EL filter if a condition is present
-            if(handlerConfig.condition() != null){
+            if(handlerConfig.condition().length() > 0){
                 if (!ElFilter.isELAvailable()) {
                     throw new IllegalStateException("A handler uses an EL filter but no EL implementation is available.");
                 }

src/test/java/net/engio/mbassy/AllTests.java

@@ -22,7 +22,8 @@ import org.junit.runners.Suite;
         DeadMessageTest.class,
         SynchronizedHandlerTest.class,
         SubscriptionManagerTest.class,
-        AsyncFIFOBusTest.class
+        AsyncFIFOBusTest.class,
+        ConditionalHandlers.class
 })
 public class AllTests {
 }

src/test/java/net/engio/mbassy/ConditionalHandlers.java

@@ -17,7 +17,7 @@ import java.util.Set;
  * Some unit tests for the "condition" filter.
  ****************************************************************************/
 
-public class ConditionTest extends MessageBusTest {
+public class ConditionalHandlers extends MessageBusTest {
 
 	public static class TestEvent {
 

src/test/java/net/engio/mbassy/common/ListenerFactory.java

@@ -30,7 +30,7 @@ public class ListenerFactory {
         return this;
     }
 
-    public ListenerFactory create(int numberOfInstances, Class[] classes){
+    public ListenerFactory create(int numberOfInstances, Class ...classes){
         for(Class clazz : classes)
             create(numberOfInstances,clazz);
         return this;