dorkbox/Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Network dispatcher is now it's own thread pool, separate from the standard kotlin coroutine dispatcher (this was to prevent thread starvation)

Browse Source
This commit is contained in:
Robinson 2022-07-17 23:05:32 -04:00
parent 6ebd4afa90
commit 14aa087eda
No known key found for this signature in database
GPG Key ID: 8E7DB78588BD6F5C
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/dorkbox/network/Configuration.kt
View File

@ -29,7 +29,7 @@ import io.aeron.driver.Configuration
import io.aeron.driver.ThreadingMode
import io.aeron.exceptions.DriverTimeoutException
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.asCoroutineDispatcher
import mu.KLogger
import org.agrona.SystemUtil
import org.agrona.concurrent.AgentTerminationException
@ -150,6 +150,8 @@ open class Configuration {
@Volatile
private var alreadyShownTips = false
private val networkDispatcher = Executors.newWorkStealingPool().asCoroutineDispatcher()
}
/**
@ -258,10 +260,20 @@ open class Configuration {
}
/**
* The dispatch responsible for executing events that arrive via the network. Normally, events should be
* dispatched asynchronously across a thread pool, but in certain circumstances you may want to constrain this to a single thread dispatcher, I/O, or a custom dispatcher.
* The dispatch responsible for executing events that arrive via the network.
*
* This is very specifically NOT 'CoroutineScope(Dispatchers.Default)', because it is very easy (and tricky) to make sure
* that there is no thread starvation going on, which can, and WILL happen.
*
* Normally, events should be dispatched asynchronously across a thread pool, but in certain circumstances you may want to constrain this to a single thread dispatcher or other, custom dispatcher.
*/
var dispatch = CoroutineScope(networkDispatcher)
/**
* Allows the user to change how endpoint settings and public key information are saved.
*
* Note: This field is overridden for server configurations, so that the file used is different for client/server
*/
var dispatch = CoroutineScope(Dispatchers.Default)
/**
* Allows the user to change how endpoint settings and public key information are saved.
@ -277,6 +289,10 @@ open class Configuration {
/**
* Specify the serialization manager to use. The type must extend `Connection`, since this will be cast
*/
/**
* Specify the serialization manager to use. The type must extend `Connection`, since this will be cast
*/
var serialization: Serialization<*> = Serialization<Connection>()
set(value) {
require(!contextDefined) { errorMessage }