code polish

This commit is contained in:
nathan 2017-11-08 11:38:22 +01:00
parent ecce442137
commit 34f4ec836d

View File

@ -303,8 +303,7 @@ class DnsNameResolverContext<T> {
resolveQuery(nameServerAddrStream, resolveQuery(nameServerAddrStream,
nameServerAddrStreamIndex, nameServerAddrStreamIndex,
question, question,
parent.dnsQueryLifecycleObserverFactory() parent.dnsQueryLifecycleObserverFactory().newDnsQueryLifecycleObserver(question),
.newDnsQueryLifecycleObserver(question),
promise); promise);
} }
@ -387,6 +386,7 @@ class DnsNameResolverContext<T> {
final DnsResponse res = envelope.content(); final DnsResponse res = envelope.content();
final int code = res.getHeader() final int code = res.getHeader()
.getRcode(); .getRcode();
if (code == DnsResponseCode.NOERROR) { if (code == DnsResponseCode.NOERROR) {
if (handleRedirect(question, envelope, queryLifecycleObserver, promise)) { if (handleRedirect(question, envelope, queryLifecycleObserver, promise)) {
// Was a redirect so return here as everything else is handled in handleRedirect(...) // Was a redirect so return here as everything else is handled in handleRedirect(...)
@ -409,7 +409,11 @@ class DnsNameResolverContext<T> {
// Retry with the next server if the server did not tell us that the domain does not exist. // Retry with the next server if the server did not tell us that the domain does not exist.
if (code != DnsResponseCode.NXDOMAIN) { if (code != DnsResponseCode.NXDOMAIN) {
resolveQuery(nameServerAddrStream, nameServerAddrStreamIndex + 1, question, queryLifecycleObserver.queryNoAnswer(code), promise); resolveQuery(nameServerAddrStream,
nameServerAddrStreamIndex + 1,
question,
queryLifecycleObserver.queryNoAnswer(code),
promise);
} }
else { else {
queryLifecycleObserver.queryFailed(NXDOMAIN_QUERY_FAILED_EXCEPTION); queryLifecycleObserver.queryFailed(NXDOMAIN_QUERY_FAILED_EXCEPTION);