dorkbox
/
Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Moved ping to the connection object

This commit is contained in:
Robinson 2023-09-05 12:58:38 +02:00
parent effed36faf
commit 3e9a8f9c74
No known key found for this signature in database
GPG Key ID: 8E7DB78588BD6F5C
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/dorkbox/network/Client.kt
View File

@ -950,11 +950,11 @@ open class Client<CONNECTION : Connection>(
*
* @return true if the ping was successfully sent to the client
*/
fun ping(pingTimeoutSeconds: Int = config.pingTimeoutSeconds, function: Ping.() -> Unit): Boolean {
fun ping(function: Ping.() -> Unit): Boolean {
val c = connection0
if (c != null) {
return super.ping(c, pingTimeoutSeconds, function)
return super.ping(c, function)
} else {
val exception = TransmitException("Cannot send a ping when there is no connection!")
listenerManager.notifyError(exception)

12
src/dorkbox/network/Configuration.kt
View File

@ -437,15 +437,6 @@ abstract class Configuration protected constructor() {
field = value
}
/**
* Changes the default ping timeout, used to test the liveliness of a connection, specifically it's round-trip performance
*/
var pingTimeoutSeconds = 30
set(value) {
require(!contextDefined) { errorMessage }
field = value
}
/**
* Allows the user to change how endpoint settings and public key information are saved.
*
@ -1034,7 +1025,6 @@ abstract class Configuration protected constructor() {
config.connectionCloseTimeoutInSeconds = connectionCloseTimeoutInSeconds
config.connectionExpirationTimoutNanos = connectionExpirationTimoutNanos
config.isReliable = isReliable
config.pingTimeoutSeconds = pingTimeoutSeconds
config.settingsStore = settingsStore
config.serialization = serialization
config.maxStreamSizeInMemoryMB = maxStreamSizeInMemoryMB
@ -1097,7 +1087,6 @@ abstract class Configuration protected constructor() {
if (connectionExpirationTimoutNanos != other.connectionExpirationTimoutNanos) return false
if (isReliable != other.isReliable) return false
if (pingTimeoutSeconds != other.pingTimeoutSeconds) return false
if (settingsStore != other.settingsStore) return false
if (serialization != other.serialization) return false
if (maxStreamSizeInMemoryMB != other.maxStreamSizeInMemoryMB) return false
@ -1124,7 +1113,6 @@ abstract class Configuration protected constructor() {
result = 31 * result + enableRemoteSignatureValidation.hashCode()
result = 31 * result + ipcId
result = 31 * result + udpId
result = 31 * result + pingTimeoutSeconds
result = 31 * result + connectionCloseTimeoutInSeconds
result = 31 * result + connectionExpirationTimoutNanos.hashCode()
result = 31 * result + isReliable.hashCode()