Optimize IPv4 -> String call in registration stack

This commit is contained in:
nathan 2019-01-16 22:41:02 +01:00
parent fbc253d3fc
commit 5000fdd264
2 changed files with 3 additions and 9 deletions

View File

@ -332,7 +332,7 @@ task<JavaCompile>("compileUtils") {
"dorkbox.util.MathUtil",
"dorkbox.util.MersenneTwisterFast",
"dorkbox.util.NativeLoader",
"dorkbox.util.NativeLoader",
"dorkbox.util.NetworkUtil",
"dorkbox.util.generics.TypeResolver",
// "dorkbox.util.generics.DefaultMethodHelper", // this class must be compiled java 8+

View File

@ -17,7 +17,6 @@ package dorkbox.network.connection;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.UnknownHostException;
import java.security.SecureRandom;
import java.util.LinkedList;
import java.util.List;
@ -34,6 +33,7 @@ import dorkbox.network.pipeline.udp.KryoDecoderUdpCrypto;
import dorkbox.network.pipeline.udp.KryoEncoderUdp;
import dorkbox.network.pipeline.udp.KryoEncoderUdpCrypto;
import dorkbox.network.serialization.CryptoSerializationManager;
import dorkbox.util.NetworkUtil;
import dorkbox.util.RandomUtil;
import dorkbox.util.collections.IntMap.Values;
import dorkbox.util.collections.LockFreeIntMap;
@ -165,13 +165,7 @@ class RegistrationWrapper {
else {
// COMPARE!
if (!CryptoECC.compare(publicKey, savedPublicKey)) {
String byAddress;
try {
byAddress = InetAddress.getByAddress(hostAddress)
.getHostAddress();
} catch (UnknownHostException e) {
byAddress = "Unknown Address";
}
String byAddress = NetworkUtil.ipv4ToString(hostAddress);
if (this.endPoint.disableRemoteKeyValidation) {
logger2.warn("Invalid or non-matching public key from remote connection, their public key has changed. Toggling extra flag in channel to indicate key change. To fix, remove entry for: {}", byAddress);