dorkbox/Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

removed ping timeout

Browse Source
This commit is contained in:
Robinson 2022-06-11 23:52:33 +02:00
parent 3dd333269e
commit 5b2b43b73e
No known key found for this signature in database
GPG Key ID: 8E7DB78588BD6F5C
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/dorkbox/network/ping/PingManager.kt
View File

@ -45,7 +45,7 @@ internal class PingManager<CONNECTION : Connection> {
// process the ping message so that our ping callback does something // process the ping message so that our ping callback does something
// this will be null if the ping took longer than 30 seconds and was cancelled // this will be null if the ping took longer than XXX seconds and was cancelled
val result = responseManager.getWaiterCallback(rmiId, logger) as (suspend Ping.() -> Unit)? val result = responseManager.getWaiterCallback(rmiId, logger) as (suspend Ping.() -> Unit)?
if (result != null) { if (result != null) {
result(ping) result(ping)
@ -72,14 +72,7 @@ internal class PingManager<CONNECTION : Connection> {
ping.packedId = id ping.packedId = id
ping.pingTime = System.currentTimeMillis() ping.pingTime = System.currentTimeMillis()
// NOTE: the timout MUST NOT be more than the max SHORT value! // ALWAYS cancel the ping after XXX seconds
if (pingTimeoutSeconds > 60) {
// just over 1 minute timeout.
throw IllegalArgumentException("Ping timeout parameter `pingTimeoutSeconds` cannot exceed 60 seconds")
}
// ALWAYS cancel the ping after 30 seconds
responseManager.cancelRequest(actionDispatch, TimeUnit.SECONDS.toMillis(pingTimeoutSeconds.toLong()), id, logger) { responseManager.cancelRequest(actionDispatch, TimeUnit.SECONDS.toMillis(pingTimeoutSeconds.toLong()), id, logger) {
// kill the callback, since we are now "cancelled". If there is a race here (and the response comes at the exact same time) // kill the callback, since we are now "cancelled". If there is a race here (and the response comes at the exact same time)
// we don't care since either it will be null or it won't (if it's not null, it will run the callback) // we don't care since either it will be null or it won't (if it's not null, it will run the callback)