dorkbox
/
Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed dead code, added pingTimeout

This commit is contained in:
Robinson 2023-05-28 19:19:37 +02:00
parent 0aaff26e69
commit 698a669d60
No known key found for this signature in database
GPG Key ID: 8E7DB78588BD6F5C
2 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/dorkbox/network/Configuration.kt
View File

@ -298,13 +298,6 @@ abstract class Configuration {
field = value
}
var controlPort: Int = 0
set(value) {
require(!contextDefined) { errorMessage }
field = value
}
/**
* How long a connection must be disconnected before we cleanup the memory associated with it
*/
@ -350,6 +343,14 @@ abstract class Configuration {
field = value
}
/**
* Changes the default ping timeout, used to test the liveliness of a connection, specifically it's round-trip performance
*/
var pingTimeoutSeconds = 30
set(value) {
require(!contextDefined) { errorMessage }
field = value
}
/**
* Specifies the Java thread that will poll the underlying network for incoming messages
@ -888,11 +889,11 @@ abstract class Configuration {
if (enableIpc != other.enableIpc) return false
if (enableRemoteSignatureValidation != other.enableRemoteSignatureValidation) return false
if (port != other.port) return false
if (controlPort != other.controlPort) return false
if (connectionCloseTimeoutInSeconds != other.connectionCloseTimeoutInSeconds) return false
if (connectionCheckIntervalNanos != other.connectionCheckIntervalNanos) return false
if (connectionExpirationTimoutNanos != other.connectionExpirationTimoutNanos) return false
if (isReliable != other.isReliable) return false
if (pingTimeoutSeconds != other.pingTimeoutSeconds) return false
if (settingsStore != other.settingsStore) return false
if (serialization != other.serialization) return false
if (pollIdleStrategy != other.pollIdleStrategy) return false
@ -914,7 +915,7 @@ abstract class Configuration {
result = 31 * result + enableIpc.hashCode()
result = 31 * result + enableRemoteSignatureValidation.hashCode()
result = 31 * result + port
result = 31 * result + controlPort
result = 31 * result + pingTimeoutSeconds
result = 31 * result + connectionCloseTimeoutInSeconds
result = 31 * result + connectionCheckIntervalNanos.hashCode()
result = 31 * result + connectionExpirationTimoutNanos.hashCode()

7
src/dorkbox/network/ping/PingManager.kt
View File

@ -15,8 +15,6 @@
*/
@file:Suppress("UNUSED_PARAMETER")
package dorkbox.network.ping
import dorkbox.network.connection.Connection
@ -28,11 +26,6 @@ import java.util.concurrent.*
* How to handle ping messages
*/
internal class PingManager<CONNECTION : Connection> {
companion object {
val DEFAULT_TIMEOUT_SECONDS = 30
}
@Suppress("UNCHECKED_CAST")
suspend fun manage(connection: CONNECTION, responseManager: ResponseManager, ping: Ping, logger: KLogger) {
if (ping.pongTime == 0L) {
ping.pongTime = System.currentTimeMillis()