dorkbox
/
Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Wrapped potential RMI errors in exception catching

This commit is contained in:
Robinson 2023-10-26 21:13:21 +02:00
parent f531f61a53
commit 737b68549c
No known key found for this signature in database
GPG Key ID: 8E7DB78588BD6F5C
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/dorkbox/network/rmi/RmiManagerConnections.kt
View File

@ -53,13 +53,20 @@ class RmiManagerConnections<CONNECTION: Connection> internal constructor(
listenerManager.notifyError(connection, newException)
ConnectionObjectCreateResponse(RmiUtils.packShorts(callbackId, RemoteObjectStorage.INVALID_RMI))
} else {
val rmiId = connection.rmi.saveImplObject(implObject)
if (rmiId == RemoteObjectStorage.INVALID_RMI) {
val newException = RMIException("Unable to create RMI object, invalid RMI ID")
listenerManager.notifyError(connection, newException)
}
try {
val rmiId = connection.rmi.saveImplObject(implObject)
if (rmiId == RemoteObjectStorage.INVALID_RMI) {
val newException = RMIException("Unable to create RMI object, invalid RMI ID")
listenerManager.notifyError(connection, newException)
}
ConnectionObjectCreateResponse(RmiUtils.packShorts(callbackId, rmiId))
ConnectionObjectCreateResponse(RmiUtils.packShorts(callbackId, rmiId))
}
catch (e: Exception) {
val newException = RMIException("Error saving the RMI implementation object!", e)
listenerManager.notifyError(connection, newException)
ConnectionObjectCreateResponse(RmiUtils.packShorts(callbackId, RemoteObjectStorage.INVALID_RMI))
}
}
// we send the message ALWAYS, because the client needs to know it worked or not