dorkbox/Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Added more explicit details on why UDP can fail

Browse Source
This commit is contained in:
nathan 2019-01-10 20:53:19 +01:00
parent d662f5c37c
commit 7b89fc6443
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/dorkbox/network/connection/RegistrationWrapper.java
View File

@ -80,12 +80,12 @@ class RegistrationWrapper {
}
public
CryptoSerializationManager getSerializtion() {
CryptoSerializationManager getSerialization() {
return endPoint.getSerialization();
}
/**
* The amount of milli-seconds that must elapse with no read or write before {@link Listener:idle()} will be triggered
* The amount of milli-seconds that must elapse with no read or write before Listener.OnIdle() will be triggered
*/
public
int getIdleTimeout() {

2
src/dorkbox/network/connection/registration/remote/RegistrationRemoteHandler.java
View File

@ -77,7 +77,7 @@ class RegistrationRemoteHandler extends RegistrationHandler {
RegistrationRemoteHandler(final String name, final RegistrationWrapper registrationWrapper, final EventLoopGroup workerEventLoop) {
super(name, registrationWrapper, workerEventLoop);
this.serializationManager = registrationWrapper.getSerializtion();
this.serializationManager = registrationWrapper.getSerialization();
}
/**

9
test/dorkbox/network/ReconnectTest.java
View File

@ -154,7 +154,14 @@ class ReconnectTest extends BaseTest {
if (waitingRetryCount-- < 0) {
System.err.println("Aborting unit test... wrong count!");
if (useUDP) {
System.err.println("NOTE: UDP can fail, even on loopback!");
// If TCP and UDP both fill the pipe, THERE WILL BE FRAGMENTATION and dropped UDP packets!
// it results in severe UDP packet loss and contention.
//
// http://www.isoc.org/INET97/proceedings/F3/F3_1.HTM
// also, a google search on just "INET97/proceedings/F3/F3_1.HTM" turns up interesting problems.
// Usually it's with ISPs.
System.err.println("NOTE: UDP can fail, even on loopback! See: http://www.isoc.org/INET97/proceedings/F3/F3_1.HTM");
}
stopEndPoints();
assertEquals(target, this.receivedCount.get());