dorkbox/Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed unchecked cast suppression

Browse Source
This commit is contained in:
Robinson 2021-04-02 15:15:01 +02:00
parent ec5dd55fee
commit bb77a17158
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/dorkbox/network/Client.kt
View File

@ -411,7 +411,6 @@ open class Client<CONNECTION : Connection>(config: Configuration = Configuration
remoteAddress!! remoteAddress!!
// VALIDATE are we allowed to connect to this server (now that we have the initial server information) // VALIDATE are we allowed to connect to this server (now that we have the initial server information)
@Suppress("UNCHECKED_CAST")
val permitConnection = listenerManager.notifyFilter(newConnection) val permitConnection = listenerManager.notifyFilter(newConnection)
if (!permitConnection) { if (!permitConnection) {
handshakeConnection.close() handshakeConnection.close()

8
src/dorkbox/network/handshake/ServerHandshake.kt
View File

@ -29,11 +29,7 @@ import dorkbox.network.connection.Connection
import dorkbox.network.connection.ConnectionParams import dorkbox.network.connection.ConnectionParams
import dorkbox.network.connection.ListenerManager import dorkbox.network.connection.ListenerManager
import dorkbox.network.connection.PublicKeyValidationState import dorkbox.network.connection.PublicKeyValidationState
import dorkbox.network.exceptions.AllocationException import dorkbox.network.exceptions.*
import dorkbox.network.exceptions.ClientException
import dorkbox.network.exceptions.ClientRejectedException
import dorkbox.network.exceptions.ClientTimedOutException
import dorkbox.network.exceptions.ServerException
import io.aeron.Aeron import io.aeron.Aeron
import io.aeron.Publication import io.aeron.Publication
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
@ -293,7 +289,6 @@ internal class ServerHandshake<CONNECTION : Connection>(private val logger: KLog
val connection = server.newConnection(ConnectionParams(server, clientConnection, PublicKeyValidationState.VALID)) val connection = server.newConnection(ConnectionParams(server, clientConnection, PublicKeyValidationState.VALID))
// VALIDATE:: are we allowed to connect to this server (now that we have the initial server information) // VALIDATE:: are we allowed to connect to this server (now that we have the initial server information)
@Suppress("UNCHECKED_CAST")
val permitConnection = listenerManager.notifyFilter(connection) val permitConnection = listenerManager.notifyFilter(connection)
if (!permitConnection) { if (!permitConnection) {
// have to unwind actions! // have to unwind actions!
@ -476,7 +471,6 @@ internal class ServerHandshake<CONNECTION : Connection>(private val logger: KLog
val connection = server.newConnection(ConnectionParams(server, clientConnection, validateRemoteAddress)) val connection = server.newConnection(ConnectionParams(server, clientConnection, validateRemoteAddress))
// VALIDATE:: are we allowed to connect to this server (now that we have the initial server information) // VALIDATE:: are we allowed to connect to this server (now that we have the initial server information)
@Suppress("UNCHECKED_CAST")
val permitConnection = listenerManager.notifyFilter(connection) val permitConnection = listenerManager.notifyFilter(connection)
if (!permitConnection) { if (!permitConnection) {
// have to unwind actions! // have to unwind actions!