dorkbox/Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Better error when client subscrition cannot connect. Added comments about publications

Browse Source
This commit is contained in:
nathan 2020-09-18 01:09:18 +02:00
parent b9c0e6b29f
commit bf457b6d69
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/dorkbox/network/aeron/MediaDriverConnection.kt
View File

@ -118,6 +118,8 @@ class UdpMediaDriverConnection(override val address: InetAddress,
// NOTE: Handlers are called on the client conductor thread. The client conductor thread expects handlers to do safe // NOTE: Handlers are called on the client conductor thread. The client conductor thread expects handlers to do safe
// publication of any state to other threads and not be long running or re-entrant with the client. // publication of any state to other threads and not be long running or re-entrant with the client.
// on close, the publication CAN linger (in case a client goes away, and then comes back)
// AERON_PUBLICATION_LINGER_TIMEOUT, 5s by default (this can also be set as a URI param)
val publication = aeron.addPublication(publicationUri.build(), streamId) val publication = aeron.addPublication(publicationUri.build(), streamId)
val subscription = aeron.addSubscription(subscriptionUri.build(), streamId) val subscription = aeron.addSubscription(subscriptionUri.build(), streamId)
@ -132,12 +134,12 @@ class UdpMediaDriverConnection(override val address: InetAddress,
break break
} }
delay(timeMillis = 10L) delay(timeMillis = 100L)
} }
if (!success) { if (!success) {
subscription.close() subscription.close()
throw ClientTimedOutException("Creating subscription connection to aeron") throw ClientTimedOutException("Cannot create subscription!")
} }
@ -151,7 +153,7 @@ class UdpMediaDriverConnection(override val address: InetAddress,
break break
} }
delay(timeMillis = 10L) delay(timeMillis = 100L)
} }
if (!success) { if (!success) {
@ -191,6 +193,8 @@ class UdpMediaDriverConnection(override val address: InetAddress,
// NOTE: Handlers are called on the client conductor thread. The client conductor thread expects handlers to do safe // NOTE: Handlers are called on the client conductor thread. The client conductor thread expects handlers to do safe
// publication of any state to other threads and not be long running or re-entrant with the client. // publication of any state to other threads and not be long running or re-entrant with the client.
// on close, the publication CAN linger (in case a client goes away, and then comes back)
// AERON_PUBLICATION_LINGER_TIMEOUT, 5s by default (this can also be set as a URI param)
// If we start/stop too quickly, we might have the address already in use! Retry a few times. // If we start/stop too quickly, we might have the address already in use! Retry a few times.
var count = 10 var count = 10
@ -200,7 +204,7 @@ class UdpMediaDriverConnection(override val address: InetAddress,
break break
} catch (e: Exception) { } catch (e: Exception) {
logger.warn(e) { "Unable to add a publication to Aeron. Retrying $count more times..." } logger.warn(e) { "Unable to add a publication to Aeron. Retrying $count more times..." }
delay(5000) delay(5_000)
} }
} }
@ -313,7 +317,7 @@ class IpcMediaDriverConnection(override val streamId: Int,
break break
} }
delay(timeMillis = 10L) delay(timeMillis = 100L)
} }
if (!success) { if (!success) {
@ -332,7 +336,7 @@ class IpcMediaDriverConnection(override val streamId: Int,
break break
} }
delay(timeMillis = 10L) delay(timeMillis = 100L)
} }
if (!success) { if (!success) {