dorkbox/Network
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Signature parameter name clarification

Browse Source
This commit is contained in:
nathan 2018-01-18 14:19:38 +01:00
parent 33f8f0843e
commit d7b7f94c1e
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dorkbox/network/connection/ConnectionImpl.java
View File

@ -1103,11 +1103,11 @@ class ConnectionImpl extends ChannelInboundHandlerAdapter implements ICryptoConn
* Used by RMI for the CLIENT side, to get the proxy object as an interface * Used by RMI for the CLIENT side, to get the proxy object as an interface
* *
* @param objectID is the RMI object ID * @param objectID is the RMI object ID
* @param type must be the interface the proxy will bind to * @param iFace must be the interface the proxy will bind to
*/ */
@Override @Override
public public
RemoteObject getProxyObject(final int objectID, final Class<?> type) { RemoteObject getProxyObject(final int objectID, final Class<?> iFace) {
synchronized (proxyIdCache) { synchronized (proxyIdCache) {
// we want to have a connection specific cache of IDs, using weak references. // we want to have a connection specific cache of IDs, using weak references.
// because this is PER CONNECTION, this is safe. // because this is PER CONNECTION, this is safe.
@ -1115,7 +1115,7 @@ class ConnectionImpl extends ChannelInboundHandlerAdapter implements ICryptoConn
if (remoteObject == null) { if (remoteObject == null) {
// duplicates are fine, as they represent the same object (as specified by the ID) on the remote side. // duplicates are fine, as they represent the same object (as specified by the ID) on the remote side.
remoteObject = rmiBridge.createProxyObject(this, objectID, type); remoteObject = rmiBridge.createProxyObject(this, objectID, iFace);
proxyIdCache.put(objectID, remoteObject); proxyIdCache.put(objectID, remoteObject);
} }

7
src/dorkbox/network/connection/IRmiConnection.java
View File

@ -26,12 +26,15 @@ interface IRmiConnection {
/** /**
* Used by RMI for the LOCAL side, to get the proxy object as an interface * Used by RMI for the LOCAL side, to get the proxy object as an interface
* *
* @param type must be the interface the proxy will bind to * @param objectID this is the RMI object ID
* @param iFace must be the interface the proxy will bind to
*/ */
RemoteObject getProxyObject(final int objectID, final Class<?> type); RemoteObject getProxyObject(final int objectID, final Class<?> iFace);
/** /**
* This is used by RMI for the REMOTE side, to get the implementation * This is used by RMI for the REMOTE side, to get the implementation
*
* @param objectID this is the RMI object ID
*/ */
Object getImplementationObject(final int objectID); Object getImplementationObject(final int objectID);