From eaabd91080e9fbeb837404197e450b8f15771ebe Mon Sep 17 00:00:00 2001 From: nathan Date: Thu, 29 Mar 2018 16:08:00 +0200 Subject: [PATCH] DNS Flags.isFlag() will not throw an exception, it will only return true or false. --- test/dorkbox/network/dns/FlagsTest.java | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/test/dorkbox/network/dns/FlagsTest.java b/test/dorkbox/network/dns/FlagsTest.java index d66f90aa..0a0c499d 100644 --- a/test/dorkbox/network/dns/FlagsTest.java +++ b/test/dorkbox/network/dns/FlagsTest.java @@ -101,11 +101,7 @@ class FlagsTest extends TestCase { public void test_isFlag() { - try { - Flags.isFlag(-1); - fail("IllegalArgumentException not thrown"); - } catch (IllegalArgumentException ignored) { - } + assertFalse(Flags.isFlag(-1)); // invalid assertTrue(Flags.isFlag(0)); assertFalse(Flags.isFlag(1)); // opcode @@ -124,10 +120,6 @@ class FlagsTest extends TestCase { assertFalse(Flags.isFlag(14)); assertFalse(Flags.isFlag(15)); - try { - Flags.isFlag(16); - fail("IllegalArgumentException not thrown"); - } catch (IllegalArgumentException ignored) { - } + assertFalse(Flags.isFlag(16)); // invalid } }