From e028914b6060512a8e6787fa3654b7659c3d8084 Mon Sep 17 00:00:00 2001 From: nathan Date: Thu, 25 Oct 2018 10:59:00 +0200 Subject: [PATCH] changed visibility for restarting gnome-shell. Added more warning logs for using wayland in an unknown (for now, not ubuntu) way when trying to restart the gnome-shell. Added more comments --- src/dorkbox/systemTray/gnomeShell/Extension.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/dorkbox/systemTray/gnomeShell/Extension.java b/src/dorkbox/systemTray/gnomeShell/Extension.java index d605b14..bda5917 100644 --- a/src/dorkbox/systemTray/gnomeShell/Extension.java +++ b/src/dorkbox/systemTray/gnomeShell/Extension.java @@ -168,7 +168,7 @@ class Extension { setGsettings.start(); } - private static + public static void restartShell() { // in some situations, you can no longer restart the shell in wayland. You must logout-login for shell modifications to apply // https://mail.gnome.org/archives/commits-list/2015-March/msg01019.html @@ -185,6 +185,15 @@ class Extension { // ubuntu 17.04 is NOT WAYLAND (it's MIR) and ubuntu 17.10 is WAYLAND (and it's broken...) return; } + else { + if (SystemTray.DEBUG) { + logger.warn("Trying to restart the shell with an unknown version of wayland. Please create an issue with OS and debug information."); + } + else { + logger.warn("Trying to restart the shell with an unknown version of wayland. Please set `SystemTray.DEBUG=true;` then create an issue " + + "with OS and debug information."); + } + } } @@ -203,6 +212,7 @@ class Extension { ShellAsyncExecutor.runShell(SHELL_RESTART_COMMAND); // We don't care when the shell restarts, since WHEN IT DOES restart, our extension will show our icon. + // Until then however, there will be errors which can be ignored, because the shell-restart means everything works. } }