From d0f98e313043b9195b55ca00af65c75318305c7b Mon Sep 17 00:00:00 2001 From: Zafar Khaja Date: Tue, 29 Oct 2013 21:47:10 +0400 Subject: [PATCH] Remove redundant conditional statements --- .../com/github/zafarkhaja/semver/MetadataVersion.java | 2 +- .../com/github/zafarkhaja/semver/NormalVersion.java | 2 +- .../java/com/github/zafarkhaja/semver/Version.java | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/github/zafarkhaja/semver/MetadataVersion.java b/src/main/java/com/github/zafarkhaja/semver/MetadataVersion.java index 70fdf24..f6f9d30 100644 --- a/src/main/java/com/github/zafarkhaja/semver/MetadataVersion.java +++ b/src/main/java/com/github/zafarkhaja/semver/MetadataVersion.java @@ -73,7 +73,7 @@ class MetadataVersion implements Comparable { if (!(other instanceof MetadataVersion)) { return false; } - return compareTo((MetadataVersion) other) == 0 ? true : false; + return compareTo((MetadataVersion) other) == 0; } @Override diff --git a/src/main/java/com/github/zafarkhaja/semver/NormalVersion.java b/src/main/java/com/github/zafarkhaja/semver/NormalVersion.java index 51639b1..87a1510 100644 --- a/src/main/java/com/github/zafarkhaja/semver/NormalVersion.java +++ b/src/main/java/com/github/zafarkhaja/semver/NormalVersion.java @@ -106,7 +106,7 @@ class NormalVersion implements Comparable { if (!(other instanceof NormalVersion)) { return false; } - return compareTo((NormalVersion) other) == 0 ? true : false; + return compareTo((NormalVersion) other) == 0; } @Override diff --git a/src/main/java/com/github/zafarkhaja/semver/Version.java b/src/main/java/com/github/zafarkhaja/semver/Version.java index 74efc71..f18ad70 100644 --- a/src/main/java/com/github/zafarkhaja/semver/Version.java +++ b/src/main/java/com/github/zafarkhaja/semver/Version.java @@ -242,19 +242,19 @@ public class Version implements Comparable { } public boolean greaterThan(Version other) { - return compareTo(other) > 0 ? true : false; + return compareTo(other) > 0; } public boolean greaterThanOrEqualTo(Version other) { - return compareTo(other) >= 0 ? true : false; + return compareTo(other) >= 0; } public boolean lessThan(Version other) { - return compareTo(other) < 0 ? true : false; + return compareTo(other) < 0; } public boolean lessThanOrEqualTo(Version other) { - return compareTo(other) <= 0 ? true : false; + return compareTo(other) <= 0; } @Override @@ -265,7 +265,7 @@ public class Version implements Comparable { if (!(other instanceof Version)) { return false; } - return compareTo((Version) other) == 0 ? true : false; + return compareTo((Version) other) == 0; } @Override